Skip to content

Ignore sys.monitoring warning for 3.11 and earlier in coverage.py config #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Mar 24, 2025

The wording of the warning changed slightly from coverage.py 7.6 to 7.7:

-coverage.exceptions.CoverageWarning: sys.monitoring isn't available, using default core (no-sysmon)
+coverage.exceptions.CoverageWarning: sys.monitoring isn't available in this version, using default core (no-sysmon)

So the regex in pyproject.toml doesn't match.

Instead, let's use the no-sysmon code to disable it directly in coverage.py's config:

@hugovk hugovk added the changelog: Fixed For any bug fixes label Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (9528daf) to head (e92ba62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          11       11           
  Lines         796      796           
=======================================
  Hits          792      792           
  Misses          4        4           
Flag Coverage Δ
macos-latest 97.73% <ø> (+0.90%) ⬆️
ubuntu-latest 97.73% <ø> (+0.90%) ⬆️
windows-latest 95.97% <ø> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk hugovk enabled auto-merge (squash) March 24, 2025 14:50
@hugovk hugovk merged commit da7f7f1 into python-humanize:main Mar 24, 2025
35 checks passed
@hugovk hugovk deleted the fix-coverage-warning branch March 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants